RHEL-10: Redirect only GLib loggers to Journal #6005
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/kickstart-test --testtype smoke |
|
/kickstart-test ui_rdp |
|
/kickstart-test --testtype coverage |
|
Tested and works correctly. |
M4rtinK
approved these changes
Nov 19, 2024
We redirect all the error messages from stderr to journal in the main Anaconda process. This is mainly covering errors and warnings from GTK UI. However, this code returns FileNotFound on systems which don't have journal enabled. To fix this move this code under our existing logic for logging to journal which is enabled only on HW installations. (cherry picked from commit c9f931f) Related: RHEL-58834
Previously we redirected all output from the main Anaconda process to Journal to avoid GTK log messages (as GTK runs in the main process) from spamming TTY. Turns out this broke a couple things, such as the shell prompt in rescue mode. So drop the wholesale process output redirection and instead just redirect (hopefully) all GLib based loggers (used by GTK) to Journal. Related: RHEL-58834 (cherry picked from commit 6fa0ee4)
This place is used for all GLib imports to avoid gi.require import across the code base. Related: RHEL-58834 (cherry picked from commit 310a6c3)
This is not required because we solve that on level of LogHandler which is used in this solution. Related: RHEL-58834 (cherry picked from commit 78b9127)
Do not ignore log levels from GLib when redirecting these logs to our logs. Related: RHEL-58834 (cherry picked from commit 1b14639)
jkonecny12
force-pushed
the
rhel-10-backport-redirect-glib-to-journal
branch
from
8b8c949
to
37bd1a2
Compare
|
Good point. Thanks for spotting this! |
|
/kickstart-test --testtype smoke |
|
/kickstart-test --testtype coverage |
jkonecny12
added
the
ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we redirected all output from the main Anaconda process to Journal to avoid GTK log messages (as GTK runs in the main process) from spamming TTY. Turns out this broke a couple things, such as the shell prompt in rescue mode.
So drop the wholesale process output redirection and instead just redirect (hopefully) all GLib based loggers (used by GTK) to Journal.
Backport of:
Resolves: RHEL-58834