Missing output for download-artifact@v3

[ak-a]

https://github.com/actions/download-artifact/tree/v3?tab=readme-ov-file#download-path-output

@V3 does have an download-path output as per documentation. Can we have this added to the checks please?

https://github.com/rhysd/actionlint/blob/main/popular_actions.go#L611-L631
suggestion:

	"actions/download-artifact@v3": {
		Name: "Download a Build Artifact",
		Inputs: ActionMetadataInputs{
			"name": {"name", false},
			"path": {"path", false},
		},
		Outputs: ActionMetadataOutputs{
			"download-path": {"download-path"},
		},	},
	"actions/download-artifact@v4": {
		Name: "Download a Build Artifact",
		Inputs: ActionMetadataInputs{
			"github-token":   {"github-token", false},
			"merge-multiple": {"merge-multiple", false},
			"name":           {"name", false},
			"path":           {"path", false},
			"pattern":        {"pattern", false},
			"repository":     {"repository", false},
			"run-id":         {"run-id", false},
		},
		Outputs: ActionMetadataOutputs{
			"download-path": {"download-path"},
		},

[isaacsanders]

The output is set in the latest version of the code, it is just not declared in the action.yml

[rhysd]

This issue should be fixed by v1.7.2.

[isaacsanders]

Can you indicate where this was fixed in the diff? v1.7.1...v1.7.2 I couldn't find a location.

…

On Mon, Sep 23, 2024 at 11:54 AM Linda_pp ***@***.***> wrote: This issue should be fixed by v1.7.2 <https://github.com/rhysd/actionlint/releases/tag/v1.7.2>. — Reply to this email directly, view it on GitHub <#442 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAE7CTOX7DZ4ETOCMTJMLEDZYBBUDAVCNFSM6AAAAABM6CGGQ6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNRYHA2DAOJUHA> . You are receiving this because you commented.Message ID: ***@***.***>

[isaacsanders]

The relevant code https://github.com/rhysd/actionlint/blob/v1.7.2/popular_actions.go#L613 On Mon, Sep 23, 2024 at 6:27 PM Isaac B Sanders ***@***.***> wrote:

…

Can you indicate where this was fixed in the diff? v1.7.1...v1.7.2 I couldn't find a location. On Mon, Sep 23, 2024 at 11:54 AM Linda_pp ***@***.***> wrote: > This issue should be fixed by v1.7.2 > <https://github.com/rhysd/actionlint/releases/tag/v1.7.2>. > > — > Reply to this email directly, view it on GitHub > <#442 (comment)>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AAE7CTOX7DZ4ETOCMTJMLEDZYBBUDAVCNFSM6AAAAABM6CGGQ6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNRYHA2DAOJUHA> > . > You are receiving this because you commented.Message ID: > ***@***.***> >

[rhysd]

This commit: 51c772b

Notice that diff is not expanded by default and you need to click 'Load diff'.

[isaacsanders]

The action mentioned in the issue about (actions/download-artifact@v3) was not updated. The problem with that action can’t be automatically fixed, it needs a specific override.

[rhysd]

Okay let me check it later.

[rhysd]

I checked the source. actions/download-artifact@v3 doesn't define the output in its action.yml file so actionlint cannot know it. This is an issue of the action, not actionlint.

https://github.com/actions/download-artifact/blob/9bc31d5ccc31df68ecc42ccf4149144866c47d8a/action.yml

And I also confirmed that actions/download-artifact@v4 defines the output well.

https://github.com/actions/download-artifact/blob/fa0a91b85d4f404e444e00e005971372dc801d16/action.yml#L36

So the simple way to fix this issue is just upgrading your dependency from v3 to v4.

[isaacsanders]

We are on GHES, so we can not upgrade to v4. v3 doesn't specify the output, but it does exist.

[isaacsanders]

I'm going to see how difficult it would be to contribute the change upstream.

[isaacsanders]

actions/download-artifact#355

[rhysd]

Thanks for creating the issue. Meanwhile -ignore option would be a workaround for this.

[rhysd]

I added a workaround for this issue at d339f6e. It is shipped with the latest release v1.7.3.

https://github.com/rhysd/actionlint/releases/tag/v1.7.3

[isaacsanders]

You’re fantastic. I appreciate you.