Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add lint workflow_call input conflict with required and default #154

Merged
merged 1 commit into from
Jun 22, 2022
Merged

Add lint workflow_call input conflict with required and default #154

merged 1 commit into from
Jun 22, 2022

Conversation

sksat
Copy link
Contributor

@sksat sksat commented Jun 20, 2022

I want to lint below invalid reusable workflow

on:
  workflow_call:
    inputs:
      test_input:
        description: test
        type: string
        required: true  # set this input is required
        default: a      # but default value is provided

When we call this workflow without test_input, it results like this. I made this mistake sometimes.

The workflow is not valid. Input test_input is required, but not provided while calling.

@rhysd
Copy link
Owner

rhysd commented Jun 22, 2022 •
edited
Loading

Thank you for adding the check. It makes sense to me. I may tweak the error message later. CI is broken, but it is not related to changes by this PR. Merging.

@rhysd rhysd merged commit 1d7fd91 into rhysd:main Jun 22, 2022
rhysd added a commit that referenced this pull request Jun 23, 2022
@rhysd
add tests for workflow call's inputs validation (#154)
5f88f3f
rhysd added a commit that referenced this pull request Jun 23, 2022
@rhysd
add unit test for checking workflow call event input check (#154)
6cfb863
rhysd added a commit that referenced this pull request Jun 24, 2022
@rhysd
add document for workflow call inputs which is required and has defau…
b223611 
…lt (#154)
@rhysd
Copy link
Owner

rhysd commented Jun 26, 2022

This change was included in the latest release v1.6.14.

@sksat
Copy link
Contributor Author

sksat commented Jun 26, 2022

Sorry, I forgot to add tests... I'll be careful next time. Thanks for release!

@sksat sksat deleted the lint-workflow-input-required branch June 26, 2022 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhysd rhysd rhysd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sksat @rhysd