-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add stdin-filename support #157
Conversation
linter.go
Outdated
@@ -79,6 +79,8 @@ type LinterOptions struct { | |||
// Format is a custom template to format error messages. It must follow Go Template format and | |||
// contain at least one {{ }} placeholder. https://pkg.go.dev/text/template | |||
Format string | |||
// Set FileName for stdin | |||
StdInFileName string |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you rename this to StdinFileName
since stdin is a single word (e.g. os.Stdin
)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for reviewing. I named it to StdinFileName
.
@arahatashun When you finish to build the VS Code plugin, I would be glad to hear that. I'll update document to include the URL to the project. |
Co-authored-by: Linda_pp <rhysd@users.noreply.github.com>
Thanks! |
This change was included in the latest release v1.6.14. |
Thank you for the quick release. I published the VSCode extension https://marketplace.visualstudio.com/items?itemName=arahata.linter-actionlint. |
@rhysd Can you add a reference to the vscode extension in the docs now? |
I'm sorry for catching the comment lately since this issue was already closed. I added description about the VS Code extension. Thank you for making it! |
What
add support for overwriting file names when using stdin.
Why
When I tried developing a VSCode extension for actionlint, I felt it would be helpful if we had this option.
FYI: https://github.com/fnando/vscode-linter/blob/main/docs/creating-linters.md
For example, eslint has this kind of option. https://eslint.org/docs/user-guide/command-line-interface#--stdin-filename
QA
With --stdin-filename
Without --stdin-filename