Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade github.com/robfig/cron and golang.org/x/sys #322

Merged
merged 3 commits into from
Jul 23, 2023

Conversation

harryzcy
Copy link
Contributor

@harryzcy harryzcy commented Jul 22, 2023

Upgrade golang.org/x/sys
Upgrade github.com/robfig/cron to v3

  • The package is non breaking in this case. It's not including optional second in cron spec by default. But we are using cron.NewParser(cron.Minute | cron.Hour | cron.Dom | cron.Month | cron.Dow) anyways, so the parser behavior won't be changed.
  • The error output of invalid syntax will be changed in the following way:

Before:

test.yaml:4:13: invalid CRON format "0 */3 * *" in schedule event: Expected exactly 5 fields, found 4: 0 */3 * * [events]

After:

test.yaml:4:13: invalid CRON format "0 */3 * *" in schedule event: expected exactly 5 fields, found 4: [0 */3 * *] [events]

@rhysd
Copy link
Owner

rhysd commented Jul 23, 2023

Looks good. Thanks for catching this.

@rhysd rhysd merged commit 2602d5e into rhysd:main Jul 23, 2023
@harryzcy harryzcy deleted the upgrade-cron-sys branch July 23, 2023 04:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants