Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add gcr.io and pkg.dev to valid docker regstry domain #463

Merged
merged 1 commit into from
Oct 21, 2024
Merged

add gcr.io and pkg.dev to valid docker regstry domain #463

merged 1 commit into from
Oct 21, 2024

Conversation

takaidohigasi
Copy link
Contributor

@takaidohigasi takaidohigasi commented Oct 21, 2024 •
edited
Loading

WHAT

SSIA

Note

gcr.io and pkg.dev is docker registry domain for GCP

@takaidohigasi takaidohigasi force-pushed the add-gcr-io-to-valid-docker-regstry-domain branch from f3d455e to 7f545e5 Compare October 21, 2024 04:01
@takaidohigasi takaidohigasi changed the title add gcr.io to valid docker regstry domain add gcr.io and pkg.dev to valid docker regstry domain Oct 21, 2024
@takaidohigasi takaidohigasi force-pushed the add-gcr-io-to-valid-docker-regstry-domain branch from 7f545e5 to d3e7407 Compare October 21, 2024 04:03
rhysd
rhysd approved these changes Oct 21, 2024
View reviewed changes
Copy link
Owner

@rhysd rhysd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. It might be not possible to check Docker registries reasonably, but let us go with these checks for now.

@rhysd rhysd merged commit b7ebeb4 into rhysd:main Oct 21, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhysd rhysd rhysd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@takaidohigasi @rhysd