avoid deprecated health api #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
woeps
changed the title
woeps
changed the title
|
Please ignore CI. The actions used by the CI workflow are too old and it is not related to changes of this PR. |
rhysd
requested changes
Aug 21, 2024
autoload/health/gitmessenger.vim
Outdated
| @@ -1,8 +1,8 @@ | |||
| function! s:check_job() abort | |||
| if !has('nvim') && !has('job') | |||
| call health#report_error('Not supported since +job feature is not enabled') | |||
| call v:lua.vim.health.error('Not supported since +job feature is not enabled') | |||
There was a problem hiding this comment.
This line is not reached by Neovim. So this modification is not needed.
autoload/health/gitmessenger.vim
Outdated
| @@ -63,13 +63,13 @@ function! s:check_vim_version() abort | |||
| endif | |||
|
|
|||
| if v:version < 800 | |||
| call health#report_error( | |||
| call v:lua.vim.health.error( | |||
autoload/health/gitmessenger.vim
Outdated
| \ 'Your Vim version is too old: ' . v:version, | ||
| \ 'Please install Vim 8.0 or later') | ||
| return | ||
| endif | ||
|
|
||
| call health#report_ok('Vim version is fine: ' . v:version) | ||
| call v:lua.vim.health.ok('Vim version is fine: ' . v:version) |
|
I've fixed CI. Please rebase this branch onto the latest master branch so that tests can be run properly. |
Nice, thanks. |
|
Sorry for the delay, I hope this is fine now. |
rhysd
approved these changes
Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #93: Deprecated (since neovim 0.10)
health#report_*calls got replaced withv:lua.vim.health.*calls.Tested in neovim 0.11.