Add support for sign extension instructions. #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Proposal https://github.com/WebAssembly/sign-extension-ops added the following instructions for sign-extending integers: 0xC0 i32.extend8_s 0xC1 i32.extend16_s 0xC2 i64.extend8_s 0xC3 i64.extend16_s 0xC4 i64.extend32_s These instructions are now in widespread use, including in WASM generated by LLVM (e.g. when compiling Rust).
rhysd
requested changes
Nov 17, 2023
jmillikin
force-pushed
the
sign-extension-ops
branch
from
b344b24
to
74e37b4
Compare
Done. |
rhysd
approved these changes
Nov 18, 2023
|
I'll fix clippy warnings locally. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposal https://github.com/WebAssembly/sign-extension-ops added the following instructions for sign-extending integers:
These instructions are now in widespread use, including in WASM generated by LLVM (e.g. when compiling Rust).