Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Loosen same-group permissions for folders and logs #189

Merged
merged 1 commit into from
Jan 2, 2024
Merged

Loosen same-group permissions for folders and logs #189

merged 1 commit into from
Jan 2, 2024

Conversation

AroneyS
Copy link
Collaborator

@AroneyS AroneyS commented Jan 2, 2024

Fixes #188

@AroneyS AroneyS requested a review from rhysnewell January 2, 2024 05:47
rhysnewell
rhysnewell reviewed Jan 2, 2024
View reviewed changes
Copy link
Owner

@rhysnewell rhysnewell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not place a single shell command in the onstart block of code?

@AroneyS
Copy link
Collaborator Author

AroneyS commented Jan 2, 2024

That doesn't work for me. I guess the log hasn't been created by then?

@AroneyS AroneyS merged commit d340802 into dev Jan 2, 2024
2 checks passed
@AroneyS AroneyS deleted the loosen-permissions branch January 2, 2024 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhysnewell rhysnewell rhysnewell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AroneyS @rhysnewell