Refactor get_qc helper functions #731
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpharrigan
changed the title
mpharrigan
changed the title
ecpeterson
approved these changes
Dec 7, 2018
|
@ecp-rigetti if you want we can merge #730 first and I'll solve the potential resulting conflicts |
|
Oh, I don't mind and I wouldn't wait. #730 realistically won't be merged for a week still, and the merge conflicts are mostly me deleting things, which I don't mind doing again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
get_qcwill return a qpu with the given name or a qvm based off of the named qpu. It also has two "hardcoded" qvms that aren't based on a real device:9q-square-qvmand{n}q-qvm. Users probably want the ability to give their own topology and/or noise model. This refactors the creation of qvms-not-based-on-a-real-device in anticipation of supporting functionality to have the user create a qvm of their liking.In particular,
_get_qvm_with_topologycan be made public, documented, and advertised for building a qvm with a custom topology.