Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove Local variants of QVMCompiler and BenchmarkConnection #730

Merged
merged 2 commits into from
Jan 24, 2019
Merged

remove Local variants of QVMCompiler and BenchmarkConnection #730

merged 2 commits into from
Jan 24, 2019

Conversation

ecpeterson
Copy link
Contributor

With the advent of an RPCQ-enabled SDK, there's no need to distinguish between local/remote communication protocols. This PR removes the HTTP-based connection classes for QVMCompiler and BenchmarkConnection and modifies the get_... calls to return the appropriate RPCQ variants all the time.

Also:

  • Add timeout fields to QVMCompiler and BenchmarkConnection for testing purposes.
  • Minor other tweaks to get the tests to pass.

Don't merge this 'til the RPCQ-enabled version of quilc is available for download.

Copy link
Contributor

@mpharrigan mpharrigan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good to go, pending availability of new quilc binary

@karalekas
Copy link
Contributor

one question: do we want to deprecate this code instead of deleting it? are we concerned about people slowly switching over to the rpcq version of quilc?

@ecpeterson
Copy link
Contributor Author

It's a thought, but I would view it more as a polite thing to do than something required by good practices. Having to update a dependent piece of Rigetti software when you update your pyQuil, which ultimately both have the same functionality in this regard, does not strike me as being too pushy.

@ecpeterson
Copy link
Contributor Author

Note to self: http://docs.rigetti.com/en/stable/start.html#server needs to get updated before this is reconsidered.

@ecpeterson
Copy link
Contributor Author

Semaphore mysteriously timed out on the RB sequence generation test, but (after rerunning it a few times with different configurations on my local machine & not being able to reproduce the error) I reran the semaphore script and it passed through. A little concerning? Or maybe it's fine!

ecpeterson and others added 2 commits January 23, 2019 11:22
also:
* add timeout fields to QVMCompiler and BenchmarkConnection for testing purposes
* update docs to match the new quilc startup flags
* minor other tweaks to get the tests to pass
@mpharrigan mpharrigan merged commit f253fb5 into rigetti:master Jan 24, 2019
@mpharrigan mpharrigan mentioned this pull request Jan 24, 2019
mpharrigan pushed a commit to mpharrigan/pyquil that referenced this pull request Jan 24, 2019
mpharrigan pushed a commit to mpharrigan/pyquil that referenced this pull request Jan 24, 2019
mpharrigan added a commit that referenced this pull request Jan 25, 2019
mpharrigan added a commit that referenced this pull request Jan 28, 2019
* Changelog for 2.3

* indent some more

* Less indenting?

* Back off gh-730

* quilc version

* Missed these changes

* community contribution
mpharrigan pushed a commit to mpharrigan/pyquil that referenced this pull request Jan 29, 2019
mpharrigan added a commit that referenced this pull request Jan 31, 2019
…nection (#730)" (#781) (#785)

* Revert "Revert "remove Local variants of QVMCompiler and BenchmarkConnection (#730)" (#781)"

This reverts commit af3edaf.

* Remove dead code part 2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants