New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Experimental gRPC web support #449

Merged

jselig-rigetti merged 79 commits into main from grpc-web-rc

Apr 4, 2024

Contributor

MarquessV commented Mar 5, 2024

No description provided.

github-actions bot commented Mar 5, 2024 •

edited

Loading

PR Preview Action v1.4.7
🚀 Deployed preview to https://rigetti.github.io/qcs-sdk-rust/pr-preview/pr-449/
on branch `qcs-sdk-python-docs` at 2024-04-04 16:43 UTC

jselig-rigetti force-pushed the grpc-web-rc branch from 2efd157 to 8c32c80 Compare

March 5, 2024 23:10

MarquessV changed the title ~~feat: Experimental gRPC web support~~ feat(python): Experimental gRPC web support

MarquessV changed the title ~~feat(python): Experimental gRPC web support~~ feat: Experimental gRPC web support

MarquessV commented

View reviewed changes

.github/workflows/create-linux-wheel.yml Outdated Show resolved Hide resolved

Cargo.toml Outdated Show resolved Hide resolved

crates/python/Cargo.toml Outdated Show resolved Hide resolved

MarquessV commented

View reviewed changes

crates/lib/src/client.rs Show resolved Hide resolved

MarquessV commented

View reviewed changes

.github/workflows/release-python-grpc-web.yml Outdated Show resolved Hide resolved

MarquessV commented

View reviewed changes

.github/workflows/release-python-grpc-web.yml Outdated Show resolved Hide resolved

jselig-rigetti mentioned this pull request

build: build linux ppc64le wheel rigetti/quil-rs#346

Merged

jselig-rigetti reviewed

View reviewed changes

.github/workflows/release-python-grpc-web.yml Outdated Show resolved Hide resolved

jselig-rigetti reviewed

View reviewed changes

.github/workflows/release-python-grpc-web.yml Outdated Show resolved Hide resolved

jselig-rigetti reviewed

View reviewed changes

.github/workflows/release-python-grpc-web.yml Outdated Show resolved Hide resolved

jselig-rigetti marked this pull request as ready for review

March 29, 2024 21:10

jselig-rigetti mentioned this pull request

Support grpc-web rigetti/pyquil#1759

Closed

Shadow53 reviewed

View reviewed changes

.github/action-common-python-release/action.yml Outdated Show resolved Hide resolved

.github/action-common-python-release/action.yml Show resolved Hide resolved

.github/workflows/release-python.yml Show resolved Hide resolved

crates/lib/src/client.rs Outdated Show resolved Hide resolved

MarquessV commented

View reviewed changes

Contributor Author

MarquessV left a comment

I can't approve because I opened the MR originally, but this is looking good. Was there a test run of the workflow that validated everything built correctly?

.github/action-common-python-release/action.yml Outdated Show resolved Hide resolved

Contributor

jselig-rigetti commented Apr 4, 2024

I can't approve because I opened the MR originally, but this is looking good. Was there a test run of the workflow that validated everything built correctly?

Yes, I validated the wheels produced from https://github.com/rigetti/qcs-sdk-rust/actions/runs/8548321434

MarquessV and others added 13 commits

April 4, 2024 10:33


          feat: Experimental gRPC web support

f56fe0b


          chore(python): add grpc-web usage

9f34ce1


          build: Create linux wheel for testing

9a68399


          use correct branch name


          Make grpc-web an opt-in feature

68da765


          remove unneeded optional


          add workflow for building qcs-sdk-python-grpc-web

1062c4c


          test workflow

3b0741d


          add ppc64le to linux archs

affd8d7


          fix python invocation


          remove grpc-web as default feature for python crate

729c2b2


          actually add script

fa120cc


          update path

5b33121

jselig-rigetti added 24 commits

April 4, 2024 10:34


          chore: simplify grpc-web package renaming script

df614e4


          chore: polish patch_grpc_web script

4592a4d


          chore: finalize package publish

2422a39


          test: try deduplicated github python publish config

769b0da


          chore: missing common checkout action

a623d1e


          chore: can't use secrets in composite actions

ba84300


          chore: add shell for composite action

2768a02


          chore: add shell for composite action

2e49362


          chore: default maturin command is build

1f77812


          chore: fix targets and maturin typo

e939e26


          chore: finalize build steps for publishing

953210a


          chore: simplify release-python.yml name

f21b27b


          chore: optionally toggle flag

4bbb511


          chore: don't publish for test

dfca7d3


          chore: fix sdist arguments

e426963


          chore: finalize for merge

75269e4


          chore: test release after mr changes

c31aaf3


          chore: update hyper-proxy only

5545bc3


          chore: add maturin targets

f832b26


          chore: split grpc web into separate job

4387f7f


          chore: fix action

4b64a99


          chore: use manylinux

e24e05d


          chore: don't try to install ppc64le wheel

7eed4c7


          chore: ready workflows for merge

57217f1

jselig-rigetti force-pushed the grpc-web-rc branch from 60baa5a to 57217f1 Compare

April 4, 2024 16:34

jselig-rigetti and others added 2 commits

April 4, 2024 10:40


          chore: remove python-version input

dae8381


          Apply suggestions from code review

8a0f2a4

Co-authored-by: Michael Bryant <mbryant@rigetti.com>

jselig-rigetti merged commit 19acacd into main

2 checks passed

jselig-rigetti deleted the grpc-web-rc branch

April 4, 2024 16:50

jselig-rigetti mentioned this pull request

open up tonic version range to include 0.11 #452

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet