open up tonic version range to include 0.11 #452
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Shadow53
approved these changes
Apr 3, 2024
There was a problem hiding this comment.
Looks fine to me, but CI checks failed, so I'm not seeing confirmation that this will compile.
Also, can we make sure this works with tonic 0.9, 0.10, and 0.11 in CI using a matrix or something? Don't want us to get burned by users using a version of tonic that isn't actually compatible with this library.
|
#449 requires particularly on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While
tonicremains pre-1.0 and this is a sweep of major versions, they are all compatible with this package and can help resolve the confusing type errors which arise when consumers rely on distinct major versions oftonic.