Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve Expression::simplify #209

Closed
wants to merge 1 commit into from

Conversation

kalzoo
Copy link
Contributor

@kalzoo kalzoo commented May 24, 2023

Closes #208

This should be considered proof-of-concept quality at this point.

Ideally, we'd be able to use a library to implement expression simplification; this is reinventing an oft-reinvented wheel. However, we do need some minimal utility here for a particular use case, and so I don't want perfect to be the enemy of minimally good.

Questions for reviewers:

  • Is there a library you'd recommend for use here?
  • Are there clever patterns we can put to work?
  • How can we prevent unbounded recursion? At a minimum, we could pass a depth argument or could recognize when simplification is recursing without modification

@kalzoo
Copy link
Contributor Author

kalzoo commented Jun 20, 2023

Superseded by #210

@kalzoo kalzoo closed this Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve Expression Simplification
1 participant