add param chord_composer/finish_chord_on_first_key_release for chord_composer, first release to finish chord
#828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lotem
requested changes
Mar 2, 2024
…d_composer, first release to finish chord.
fxliang
changed the title
chord_composer/finish_when_release for chord_composer, first release to finish chordchord_composer/finish_chord_on_first_key_release for chord_composer, first release to finish chord
2 tasks
graphemecluster
pushed a commit
to TypeDuck-HK/librime
that referenced
this pull request
Mar 18, 2024
add param `chord_composer/finish_chord_on_first_key_release`
graphemecluster
pushed a commit
to TypeDuck-HK/librime
that referenced
this pull request
Mar 18, 2024
add param `chord_composer/finish_chord_on_first_key_release`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request
Issue tracker
Fixes will automatically close the related issue
Fixes #
Feature
Describe feature of pull request
chord_composer/finish_chord_on_first_key_release: {bool}default
false, if settrue, tested in rime_api_console :Unit test
Manual test
Code Review
Additional Info