fix(chord_composer): ignore repeated keys #841
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request
Issue tracker
Fixes will automatically close the related issue
Fixes #
with #828
chord_composer/finish_chord_on_first_key_release: true
, the left keys of previous chord, may be insertedto the new chord.
test procedure (
combo_pinyin
):w
l
, getce
not finishchordl
, getce
finishchord,w
saved to the prev_pressed_w
key, system may resend keydown event ofw
, as it still in the prev_pressed_, it will not be insert to new chord pressed_s
d
j
, getshi
not finishchordw
will repeat keydown event, will still be ignored.d
, finish current chord, savesj
to prev_pressed_(withw
deleted), repeat the new loop on and on.Feature
Describe feature of pull request
Unit test
Manual test
Code Review
Additional Info