target/riscv: Don't assert in riscv013_get_register() #916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the target isn't halted, simply return an error. This used to be purely internal code so an assert was appropriate. Now after some refactoring and with unavailable harts you could get here when the hart is unavailable. In that case the right thing is simply to return an error message. Change-Id: I49d26a11fe7565c645fd2480e89a2c35ea9b1688 Signed-off-by: Tim Newsome <tim@sifive.com>
JanMatCodasip
approved these changes
Sep 14, 2023
Comment on lines
+4949
to
+4950
| LOG_TARGET_ERROR(target, "Can't save register %s on a hart that is not halted.", | ||
| gdb_regno_name(regid)); |
There was a problem hiding this comment.
If you like, the state of the target can be part of the error message. This can help in future with log analysis and troubleshooting.
Suggested change
| LOG_TARGET_ERROR(target, "Can't save register %s on a hart that is not halted.", | |
| gdb_regno_name(regid)); | |
| LOG_TARGET_ERROR(target, "Can't save register %s on a hart that is not halted (current state: %s).", | |
| gdb_regno_name(regid), target_state_name(target)); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the target isn't halted, simply return an error. This used to be purely internal code so an assert was appropriate. Now after some refactoring and with unavailable harts you could get here when the hart is unavailable. In that case the right thing is simply to return an error message.
Change-Id: I49d26a11fe7565c645fd2480e89a2c35ea9b1688