Merge pull request #306 from riscv-software-src/303-add-missing-recom…

…mendations-to-profiles Just need to add to RVA22 (already in RVA20). Also changed to bullet list for each separate recommendation.
riscv-software-src · Nov 23, 2024 · 8721e67 · 8721e67
2 parents daeadcf + 230d84f
commit 8721e67
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/arch/profile_release/RVA22.yaml b/arch/profile_release/RVA22.yaml
@@ -156,6 +156,10 @@ RVA22:
         text: |
           The Zfinx, Zdinx, Zhinx, Zhinxmin extensions are incompatible
           with the profile mandates to support the F and D extensions.
+      recommendations:
+      - text: |
+          Implementations are strongly recommended to raise illegal-instruction
+          exceptions on attempts to execute unimplemented opcodes.
     RVA22S64:
       marketing_name: RVA22S64
       mode: S
@@ -257,4 +261,8 @@ RVA22:
              * Shvstvala
              * Shtvala
              * Shvstvecd
-             * Shgatpa
+             * Shgatpa
+      recommendations:
+      - text: |
+          Implementations are strongly recommended to raise illegal-instruction
+          exceptions on attempts to execute unimplemented opcodes.
diff --git a/backends/profile_doc/templates/profile.adoc.erb b/backends/profile_doc/templates/profile.adoc.erb
@@ -390,7 +390,7 @@ associated implementation-defined parameters across all its defined profiles.
 Recommendations are not strictly mandated but are included to guide implementers making design choices.
 
 <% profile.recommendations.each do |recommendation| -%>
-<%= recommendation.text %>
+* <%= recommendation.text %>
 <% end # each recommendation -%>
 <% end # unless recommendations empty -%>