Merged F extension instructions. Some fields are not populated #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Afonso Oliveira <Afonso.Oliveira@synopsys.com>
AFOliveira
force-pushed
the
AFOliveira/mergeInstructions
branch
from
582ba5a to
1bae44e
Compare
dhower-qc
requested changes
Oct 17, 2024
There was a problem hiding this comment.
Cool. The errors you are getting with the operation() are probably just because some things have moved around since that dhower/f branch was created. It's likely a quick fix.
Would you be able to add them back in on this branch? I can then run it locally and fix it up.
Sure, give me just a couple minutes and I'll commit them here. |
Signed-off-by: Afonso Oliveira <Afonso.Oliveira@synopsys.com>
|
@dhower-qc Done! |
Closed
|
I added some missing files (fp.idl) and fixed up the IDL code where, e.g., function signatures have changed. Should pass now. |
dhower-qc
requested changes
Oct 17, 2024
Signed-off-by: Afonso Oliveira <Afonso.Oliveira@synopsys.com>
Signed-off-by: Afonso Oliveira <Afonso.Oliveira@synopsys.com>
|
@dhower-qc Unless I missed or wrongfully assigned any register, this PR is now ready. |
dhower-qc
approved these changes
Oct 18, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is only about the F extension. I merged in the info from dhower/F with the exception of operations because they were creating some errors. I haven't taken a close look to ALL fields and therefore some of them have different syntax for source registers. The html builds sucessfully with this and the regress test passes.