Skip to content
This repository has been archived by the owner on Apr 13, 2019. It is now read-only.

RV64 mstatus/status: SXL and UXL are not correctly implemented #139

Open
vsiles opened this issue Apr 30, 2018 · 2 comments
Open

RV64 mstatus/status: SXL and UXL are not correctly implemented #139

vsiles opened this issue Apr 30, 2018 · 2 comments

Comments

@vsiles
Copy link

vsiles commented Apr 30, 2018

Hi !
The misa register correctly provides the value of MXL, but the mstatus/sstatus register do not provide a valid value for the SXL and UXL bits (which are always returned as 0). For example, the documentation states that:

For RV64 and RV128 systems, if S-mode is not supported, then SXL is hardwired to zero. Other-
wise, it is a WARL field that encodes the current value of S-XLEN. In particular, the implemen-
tation may hardwire SXL so that S-XLEN = M-XLEN.

In the case of the sifive_u machine, where Supervisor mode is implemented, 0 is incorrect. Hard-wiring it MXL seems a good option to have a legal value for the time being.
@michaeljclark
Copy link
Collaborator

Thanks for the bug report. Will look into this...

@michaeljclark
Copy link
Collaborator

SXL and UXL are not implemented at all.

palmer-dabbelt pushed a commit to sifive/riscv-qemu that referenced this issue Mar 18, 2019
@a-shinkevich @kevmw
iotests: check whitelisted formats
d9df28e 
Some test cases require specific formats. The method decorator
skip_if_unsupported() checks if requested formats are whitelisted.
The test riscvarchive#139 was selected for a sample output, after running
$ ./check -qcow2 131-140

137 3s ...
138 0s ...
139 2s ...
    [case not run] testBlkDebug (__main__.TestBlockdevDel): formats ['blkdebug'] are not whitelisted
    [case not run] testBlkVerify (__main__.TestBlockdevDel): formats ['blkverify'] are not whitelisted
    [case not run] testQuorum (__main__.TestBlockdevDel): formats ['quorum'] are not whitelisted
140 0s ...
Not run: 131 135 136
Some cases not run in: 139
Passed all 7 tests

Signed-off-by: Andrey Shinkevich <andrey.shinkevich@virtuozzo.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@michaeljclark @vsiles