Skip to content

Commit

Permalink
chore: fix typo in comment (#19759)
Browse files Browse the repository at this point in the history
Signed-off-by: Richard Chien <stdrc@outlook.com>
  • Loading branch information
stdrc authored Dec 11, 2024
1 parent 9292b6f commit 572404d
Show file tree
Hide file tree
Showing 4 changed files with 10 additions and 4 deletions.
8 changes: 7 additions & 1 deletion .typos.toml
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,12 @@ mosquitto = "mosquitto" # This is a MQTT broker.
abd = "abd"
iy = "iy"
Pn = "Pn"
barreir = "barrier"
perhapts = "perhaps"
psrser = "parser"
extreact = "extract"
buidler = "builder"
epoches = "epochs"

[default.extend-identifiers]
TABLE_SCHEM = "TABLE_SCHEM"
Expand All @@ -40,5 +46,5 @@ extend-exclude = [
# We don't want to fix "Divy" here, but may want in other places.
"integration_tests/deltalake-sink/spark-script/run-sql-file.sh",
# These files are copied from debezium connector, we don't want to fix their typos
"java/connector-node/risingwave-source-cdc/src/main/java/io/debezium/connector/postgresql/*.java"
"java/connector-node/risingwave-source-cdc/src/main/java/io/debezium/connector/postgresql/*.java",
]
2 changes: 1 addition & 1 deletion src/common/src/catalog/column.rs
Original file line number Diff line number Diff line change
Expand Up @@ -550,7 +550,7 @@ pub fn debug_assert_column_ids_distinct(columns: &[ColumnCatalog]) {
);
}

/// FIXME: perhapts we should use sth like `ColumnIdGenerator::new_alter`,
/// FIXME: Perhaps we should use sth like `ColumnIdGenerator::new_alter`,
/// However, the `SourceVersion` is problematic: It doesn't contain `next_col_id`.
/// (But for now this isn't a large problem, since drop column is not allowed for source yet..)
///
Expand Down
2 changes: 1 addition & 1 deletion src/connector/codec/src/decoder/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ pub trait Access {
/// TODO: the meaning of `path` is a little confusing and maybe over-abstracted.
/// `access` does not need to serve arbitrarily deep `path` access, but just "top-level" access.
/// The API creates an illusion that arbitrary access is supported, but it's not.
/// Perhapts we should separate out another trait like `ToDatum`,
/// Perhaps we should separate out another trait like `ToDatum`,
/// which only does type mapping, without caring about the path. And `path` itself is only an `enum` instead of `&[&str]`.
///
/// What `path` to access is decided by the CDC layer, i.e., the `FORMAT ...` part (`ChangeEvent`).
Expand Down
2 changes: 1 addition & 1 deletion src/stream/src/executor/backfill/cdc/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ pub use upstream_table::external::ExternalStorageTable;
pub struct CdcScanOptions {
/// Whether to disable backfill
pub disable_backfill: bool,
/// Barreir interval to start a new snapshot read
/// Barrier interval to start a new snapshot read
pub snapshot_interval: u32,
/// Batch size for a snapshot read query
pub snapshot_batch_size: u32,
Expand Down

0 comments on commit 572404d

Please sign in to comment.