Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix typo in comment #19759

Merged
merged 4 commits into from
Dec 11, 2024
Merged

chore: fix typo in comment #19759

merged 4 commits into from
Dec 11, 2024

Conversation

stdrc
Copy link
Member

@stdrc stdrc commented Dec 11, 2024

Signed-off-by: Richard Chien stdrc@outlook.com

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

Signed-off-by: Richard Chien <stdrc@outlook.com>
@stdrc stdrc marked this pull request as ready for review December 11, 2024 08:49
@stdrc stdrc requested review from BugenZhao and xxchan December 11, 2024 08:50
Copy link
Member

@xxchan xxchan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add to typos dictionary

Copy link
Member

@BugenZhao BugenZhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also

/// FIXME: perhapts we should use sth like `ColumnIdGenerator::new_alter`,
please

Signed-off-by: Richard Chien <stdrc@outlook.com>
Signed-off-by: Richard Chien <stdrc@outlook.com>
@stdrc stdrc enabled auto-merge December 11, 2024 08:56
@graphite-app graphite-app bot requested a review from a team December 11, 2024 09:12
Signed-off-by: Richard Chien <stdrc@outlook.com>
@stdrc stdrc added this pull request to the merge queue Dec 11, 2024
Merged via the queue into main with commit 572404d Dec 11, 2024
9 checks passed
@stdrc stdrc deleted the rc/fix-typo branch December 11, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants