Skip to content

Commit

Permalink
fix(metrics): use iter_in_process_count to replace iter_count_duration (
Browse files Browse the repository at this point in the history
#3678)

fix(metrics): use iter_in_process_count to replace iter_count by histogram duration
  • Loading branch information
Li0k authored Jul 6, 2022
1 parent a75258e commit 8757d90
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 8 deletions.
2 changes: 1 addition & 1 deletion grafana/risingwave-dashboard.json

Large diffs are not rendered by default.

10 changes: 3 additions & 7 deletions grafana/risingwave-dashboard.py
Original file line number Diff line number Diff line change
Expand Up @@ -553,9 +553,6 @@ def section_hummock(panels):
panels.target(
"sum(rate(state_store_get_duration_count[1m])) by (job,instance)", "get - {{job}} @ {{instance}}"
),
panels.target(
"sum(rate(state_store_iter_duration_count[1m])) by (job,instance)", "iter - {{job}} @ {{instance}}"
),
panels.target(
"sum(rate(state_store_range_scan_duration_count[1m])) by (job,instance)", "range_scan - {{job}} @ {{instance}}"
),
Expand All @@ -565,6 +562,9 @@ def section_hummock(panels):
panels.target(
"sum(rate(state_store_get_shared_buffer_hit_counts[1m])) by (job,instance)", "shared_buffer hit - {{job}} @ {{instance}}"
),
panels.target(
"sum(rate(state_store_iter_in_process_counts[1m])) by(job,instance)", "iter_in_process_counts - {{instance}} "
),
]),
panels.timeseries_latency("Read Duration - Get", [
panels.target(
Expand Down Expand Up @@ -618,10 +618,6 @@ def section_hummock(panels):
panels.target(
"sum by(le, job, instance)(rate(state_store_iter_duration_sum[1m])) / sum by(le, job,instance) (rate(state_store_iter_duration_count[1m]))", "avg - {{job}} @ {{instance}}"
),

panels.target(
"sum(rate(state_store_iter_in_process_counts[1m])) by(job,instance)", "iter_in_process_counts - {{instance}} "
),
]),
panels.timeseries_latency("Read Duration - Iter Pure Scan", [
*quantile(lambda quantile, legend:
Expand Down

0 comments on commit 8757d90

Please sign in to comment.