Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(metrics): use iter_in_process_count to replace iter_count_duration #3678

Merged
merged 1 commit into from
Jul 6, 2022

Conversation

Li0k
Copy link
Contributor

@Li0k Li0k commented Jul 6, 2022

fix(metrics): use iter_in_process_count to replace iter_count of histogram duration

I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.

What's changed and what's your intention?

as title

Checklist

  • [ ] I have written necessary rustdoc comments
  • [ ] I have added necessary unit tests and integration tests
  • All checks passed in ./risedev check (or alias, ./risedev c)

@Li0k Li0k requested a review from skyzh July 6, 2022 03:06
@github-actions github-actions bot added the type/fix Bug fix label Jul 6, 2022
@codecov
Copy link

codecov bot commented Jul 6, 2022

Codecov Report

Merging #3678 (37fb8ab) into main (a75258e) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #3678      +/-   ##
==========================================
- Coverage   74.30%   74.30%   -0.01%     
==========================================
  Files         789      789              
  Lines      111361   111361              
==========================================
- Hits        82747    82742       -5     
- Misses      28614    28619       +5     
Flag Coverage Δ
rust 74.30% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/meta/src/manager/id.rs 94.94% <0.00%> (-1.13%) ⬇️
src/connector/src/filesystem/file_common.rs 80.35% <0.00%> (-0.45%) ⬇️
src/frontend/src/expr/utils.rs 98.99% <0.00%> (-0.26%) ⬇️
src/common/src/types/ordered_float.rs 24.70% <0.00%> (-0.20%) ⬇️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@mergify mergify bot merged commit 8757d90 into main Jul 6, 2022
@mergify mergify bot deleted the li0k/fix_iter_mertrics branch July 6, 2022 03:22
nasnoisaac pushed a commit to nasnoisaac/risingwave that referenced this pull request Aug 9, 2022
risingwavelabs#3678)

fix(metrics): use iter_in_process_count to replace iter_count by histogram duration
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/fix Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants