Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(lints): refine help message when formatting error in tracing::event #14752

Merged
merged 2 commits into from
Jan 24, 2024

Conversation

BugenZhao
Copy link
Member

@BugenZhao BugenZhao commented Jan 23, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Follow-up of #14713. See lints/ui/format_error.stderr for the effects.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • All checks passed in ./risedev check (or alias, ./risedev c)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

… `tracing::event`

Signed-off-by: Bugen Zhao <i@bugenzhao.com>
@BugenZhao BugenZhao added this pull request to the merge queue Jan 23, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 23, 2024
@BugenZhao BugenZhao enabled auto-merge January 24, 2024 02:33
@BugenZhao BugenZhao added this pull request to the merge queue Jan 24, 2024
Merged via the queue into main with commit 30fcc93 Jan 24, 2024
26 of 27 checks passed
@BugenZhao BugenZhao deleted the bz/dylint-format-error-refine-report branch January 24, 2024 03:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants