Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ci): integrate with cargo-dylint #14713

Merged
merged 13 commits into from
Jan 23, 2024
Merged

feat(ci): integrate with cargo-dylint #14713

merged 13 commits into from
Jan 23, 2024

Conversation

BugenZhao
Copy link
Member

@BugenZhao BugenZhao commented Jan 22, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Integrate cargo-dylint (introduced in #13750) into CI.

An example of failing CI: https://buildkite.com/risingwavelabs/pull-request/builds/40318#018d3030-4d84-48bd-b59f-7ba371cd2fb5

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • All checks passed in ./risedev check (or alias, ./risedev c)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@BugenZhao BugenZhao marked this pull request as ready for review January 22, 2024 05:51
@BugenZhao BugenZhao changed the title feat(ci): integrate with cargo-dylint feat(ci): integrate with cargo-dylint [WIP] Jan 22, 2024
@BugenZhao BugenZhao changed the title feat(ci): integrate with cargo-dylint [WIP] feat(ci): integrate with cargo-dylint Jan 22, 2024
@BugenZhao BugenZhao changed the base branch from main to bz/format-error-lint-fix-4 January 22, 2024 08:37
@BugenZhao BugenZhao requested a review from a team as a code owner January 22, 2024 08:49
Base automatically changed from bz/format-error-lint-fix-4 to main January 22, 2024 10:12
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
@BugenZhao BugenZhao added this pull request to the merge queue Jan 23, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 23, 2024
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
@BugenZhao BugenZhao enabled auto-merge January 23, 2024 08:34
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
@BugenZhao BugenZhao added this pull request to the merge queue Jan 23, 2024
Merged via the queue into main with commit 5436acf Jan 23, 2024
28 of 29 checks passed
@BugenZhao BugenZhao deleted the bz/ci-dylint branch January 23, 2024 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants