refactor(error): clean-up direct error formatting (part 5, done) #14956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 2, 2024
9 tasks
BugenZhao
force-pushed
the
bz/rw-error-move-into-frontend
branch
from
d62a6fc to
da33d4a
Compare
BugenZhao
force-pushed
the
bz/connector-format-error-lint
branch
from
49ebdaa to
417f040
Compare
BugenZhao
force-pushed
the
bz/rw-error-move-into-frontend
branch
from
da33d4a to
07d1685
Compare
BugenZhao
force-pushed
the
bz/connector-format-error-lint
branch
from
5965695 to
8f9ad29
Compare
BugenZhao
force-pushed
the
bz/connector-format-error-lint
branch
from
8f9ad29 to
fcbe69d
Compare
StrikeW
approved these changes
Feb 5, 2024
BugenZhao
force-pushed
the
bz/connector-format-error-lint
branch
from
fcbe69d to
e7fd3dd
Compare
4 tasks
xxchan
approved these changes
Feb 6, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
stdrc
approved these changes
Feb 7, 2024
| @@ -111,7 +111,7 @@ where | |||
| ) | |||
| }) | |||
| .await | |||
| .map_err(|e| anyhow!("failed to validate source: {:?}", e))??; | |||
| .context("failed to validate source")??; | |||
9 tasks
4 tasks
This was referenced Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Follow-up of #14713. All direct error formatting should be cleaned up after this PR, and the lints for
connectorcrate is also enabled.Checklist
./risedev check(or alias,./risedev c)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.