Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(connector): make ConnectorError a wrapper of anyhow::Error #15086

Merged
merged 3 commits into from
Feb 15, 2024

Conversation

BugenZhao
Copy link
Member

@BugenZhao BugenZhao commented Feb 13, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Make ConnectorError a wrapper of anyhow::Error without implicit casting, so that developers are forced to provide default or ad-hoc context messages when doing conversion.

Check the documentation on def_anyhow_wrapper macro for the motivation and the design.

This is another attempt to resolve #15031 (comment).

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • All checks passed in ./risedev check (or alias, ./risedev c)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@BugenZhao BugenZhao marked this pull request as ready for review February 13, 2024 06:22
@BugenZhao BugenZhao requested a review from a team as a code owner February 13, 2024 06:22
@BugenZhao BugenZhao requested review from StrikeW and xxchan February 13, 2024 06:22
Base automatically changed from bz/connector-error-use-anyhow-newtype to main February 13, 2024 06:44
src/error/src/anyhow.rs Outdated Show resolved Hide resolved
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
@BugenZhao BugenZhao force-pushed the bz/connector-error-use-anyhow-newtype-retry branch from dc3fda4 to e114eee Compare February 13, 2024 08:07
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
@BugenZhao BugenZhao requested a review from xxchan February 14, 2024 06:06
Copy link
Member

@xxchan xxchan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💕

Copy link
Contributor

@StrikeW StrikeW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@BugenZhao BugenZhao added this pull request to the merge queue Feb 15, 2024
Merged via the queue into main with commit 85dab13 Feb 15, 2024
29 of 30 checks passed
@BugenZhao BugenZhao deleted the bz/connector-error-use-anyhow-newtype-retry branch February 15, 2024 04:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants