Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(lints): lint format_error on anyhow::Error #15158

Merged
merged 5 commits into from
Feb 23, 2024

Conversation

BugenZhao
Copy link
Member

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

anyhow::Error does not implement Error trait, so they were not covered previously. This PR takes anyhow::Error into consideration, and also improves the help message for it.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • All checks passed in ./risedev check (or alias, ./risedev c)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@BugenZhao
Copy link
Member Author

There would be some more errors yielded by dylint after the change. Will also fix them in this PR.

Copy link
Member

@xxchan xxchan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rubber stamp

@BugenZhao BugenZhao force-pushed the bz/connector-migrate-anyhow-to-connector-error branch from cf13de1 to 0357432 Compare February 23, 2024 07:12
@BugenZhao BugenZhao force-pushed the bz/format-error-lint-anyhow-error branch from de83917 to 5742467 Compare February 23, 2024 07:12
@BugenZhao BugenZhao force-pushed the bz/connector-migrate-anyhow-to-connector-error branch from 0357432 to ba75e21 Compare February 23, 2024 08:57
@BugenZhao BugenZhao force-pushed the bz/format-error-lint-anyhow-error branch from 5742467 to 3c8896a Compare February 23, 2024 08:57
Base automatically changed from bz/connector-migrate-anyhow-to-connector-error to main February 23, 2024 09:25
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
@BugenZhao BugenZhao force-pushed the bz/format-error-lint-anyhow-error branch from 8670b57 to 39e5a2a Compare February 23, 2024 09:26
Copy link
Member Author

BugenZhao commented Feb 23, 2024

Merge activity

  • Feb 23, 4:26 AM EST: Graphite rebased this pull request after merging its parent, because this pull request is set to merge when ready.
  • Feb 23, 4:52 AM EST: Graphite failed to merge this pull request due to This repository has GitHub's merge queue enabled, which is currently incompatible with Graphite. Try your merge again, or report a bug if you see this consistently.

@BugenZhao BugenZhao added this pull request to the merge queue Feb 23, 2024
Merged via the queue into main with commit 5cda6dd Feb 23, 2024
28 of 29 checks passed
@BugenZhao BugenZhao deleted the bz/format-error-lint-anyhow-error branch February 23, 2024 10:04
@zwang28 zwang28 mentioned this pull request Feb 28, 2024
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants