-
Notifications
You must be signed in to change notification settings - Fork 590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(lints): lint format_error
on anyhow::Error
#15158
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There would be some more errors yielded by |
BugenZhao
force-pushed
the
bz/format-error-lint-anyhow-error
branch
from
February 22, 2024 08:55
44ebaed
to
9ebc6f1
Compare
BugenZhao
changed the base branch from
main
to
bz/connector-migrate-anyhow-to-connector-error
February 22, 2024 08:56
This was referenced Feb 22, 2024
BugenZhao
force-pushed
the
bz/format-error-lint-anyhow-error
branch
from
February 22, 2024 11:27
9ebc6f1
to
de83917
Compare
xxchan
approved these changes
Feb 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rubber stamp
9 tasks
BugenZhao
force-pushed
the
bz/connector-migrate-anyhow-to-connector-error
branch
from
February 23, 2024 07:12
cf13de1
to
0357432
Compare
BugenZhao
force-pushed
the
bz/format-error-lint-anyhow-error
branch
from
February 23, 2024 07:12
de83917
to
5742467
Compare
BugenZhao
force-pushed
the
bz/connector-migrate-anyhow-to-connector-error
branch
from
February 23, 2024 08:57
0357432
to
ba75e21
Compare
BugenZhao
force-pushed
the
bz/format-error-lint-anyhow-error
branch
from
February 23, 2024 08:57
5742467
to
3c8896a
Compare
4 tasks
Base automatically changed from
bz/connector-migrate-anyhow-to-connector-error
to
main
February 23, 2024 09:25
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
BugenZhao
force-pushed
the
bz/format-error-lint-anyhow-error
branch
from
February 23, 2024 09:26
8670b57
to
39e5a2a
Compare
Merge activity
|
9 tasks
This was referenced Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
anyhow::Error
does not implementError
trait, so they were not covered previously. This PR takesanyhow::Error
into consideration, and also improves the help message for it.Checklist
./risedev check
(or alias,./risedev c
)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.