Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(test): fix meta backup test #15320

Closed
wants to merge 1 commit into from
Closed

fix(test): fix meta backup test #15320

wants to merge 1 commit into from

Conversation

zwang28
Copy link
Contributor

@zwang28 zwang28 commented Feb 28, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Previously this test relied on risectl's exit code. But after #15158 risectl always returns code 0 even on error.
This PR fixes the test by verifying ristctl's output.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@zwang28
Copy link
Contributor Author

zwang28 commented Feb 28, 2024

@mikechesterwang @BugenZhao
RW Cloud also relies on risectl's exit code to decide whether op succeeds. Should we add the exit code back?

@BugenZhao
Copy link
Member

But after #15158 risectl always returns code 0 even on error.

Oops. This is unexpected. I'll fix that.

@fuyufjh fuyufjh changed the title chore(test): fix meta backup test fix(test): fix meta backup test Feb 28, 2024
@github-actions github-actions bot added type/fix Bug fix and removed type/chore labels Feb 28, 2024
@BugenZhao
Copy link
Member

Hi. #15325 was merged. Do we still need this workaround?

@zwang28 zwang28 closed this Mar 7, 2024
auto-merge was automatically disabled March 7, 2024 03:14

Pull request was closed

@zwang28 zwang28 deleted the wangzheng/chore_test branch March 15, 2024 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/fix Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants