Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(recovery): remove max retry attempts for recovery #6531

Merged
merged 2 commits into from
Nov 22, 2022

Conversation

yezizp2012
Copy link
Member

@yezizp2012 yezizp2012 commented Nov 22, 2022

I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.

As title, In cloud deployment, CN can be out of contact for more than a few minutes. Meta should keep trying recovery rather than exit after retry for several times.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • All checks passed in ./risedev check (or alias, ./risedev c)

Documentation

If your pull request contains user-facing changes, please specify the types of the changes, and create a release note. Otherwise, please feel free to remove this section.

Types of user-facing changes

Please keep the types that apply to your changes, and remove those that do not apply.

  • Installation and deployment
  • Connector (sources & sinks)
  • SQL commands, functions, and operators
  • RisingWave cluster configuration changes
  • Other (please specify in the release note below)

Release note

Please create a release note for your changes. In the release note, focus on the impact on users, and mention the environment or conditions where the impact may occur.

Refer to a related PR or issue link (optional)

Copy link
Contributor

@cloudcarver cloudcarver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Nov 22, 2022

Codecov Report

Merging #6531 (010c9dc) into main (213da6a) will decrease coverage by 0.04%.
The diff coverage is 62.81%.

@@            Coverage Diff             @@
##             main    #6531      +/-   ##
==========================================
- Coverage   74.01%   73.97%   -0.05%     
==========================================
  Files         983      986       +3     
  Lines      160712   161598     +886     
==========================================
+ Hits       118952   119543     +591     
- Misses      41760    42055     +295     
Flag Coverage Δ
rust 73.97% <62.81%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/batch/src/executor/mod.rs 72.30% <ø> (ø)
src/batch/src/executor/source.rs 0.00% <0.00%> (ø)
src/common/src/util/prost.rs 0.00% <0.00%> (ø)
src/compute/src/rpc/service/stream_service.rs 0.00% <0.00%> (ø)
src/frontend/src/observer/observer_manager.rs 0.00% <0.00%> (ø)
...c/frontend/src/optimizer/plan_node/batch_source.rs 0.00% <0.00%> (ø)
src/frontend/src/optimizer/plan_node/mod.rs 85.49% <ø> (ø)
src/frontend/src/optimizer/plan_node/stream.rs 13.24% <0.00%> (-0.07%) ⬇️
src/frontend/src/scheduler/distributed/stage.rs 19.92% <0.00%> (-1.09%) ⬇️
src/frontend/src/scheduler/local.rs 0.00% <0.00%> (ø)
... and 90 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mergify mergify bot merged commit 9ebcac2 into main Nov 22, 2022
@mergify mergify bot deleted the chore/keep-retry-recovery branch November 22, 2022 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants