Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(recovery): remove max retry attempts for recovery #6531

Merged
merged 2 commits into from
Nov 22, 2022
Merged

chore(recovery): remove max retry attempts for recovery #6531

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ae3923e
chore: retry until recovery success
yezizp2012 Nov 22, 2022
010c9dc
Merge branch 'main' into chore/keep-retry-recovery
mergify[bot] Nov 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions src/meta/src/barrier/recovery.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,8 +47,6 @@ where
{
// Retry base interval in milliseconds.
const RECOVERY_RETRY_BASE_INTERVAL: u64 = 100;
// Retry max attempts.
const RECOVERY_RETRY_MAX_ATTEMPTS: usize = 10;
// Retry max interval.
const RECOVERY_RETRY_MAX_INTERVAL: Duration = Duration::from_secs(10);

Expand All @@ -57,7 +55,6 @@ where
fn get_retry_strategy() -> impl Iterator<Item = Duration> {
ExponentialBackoff::from_millis(Self::RECOVERY_RETRY_BASE_INTERVAL)
.max_delay(Self::RECOVERY_RETRY_MAX_INTERVAL)
.take(Self::RECOVERY_RETRY_MAX_ATTEMPTS)
.map(jitter)
}

Expand Down