-
Notifications
You must be signed in to change notification settings - Fork 594
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(frontend): create streaming job handling #7101
Conversation
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
Codecov Report
@@ Coverage Diff @@
## main #7101 +/- ##
==========================================
- Coverage 73.19% 73.19% -0.01%
==========================================
Files 1051 1051
Lines 167386 167423 +37
==========================================
+ Hits 122515 122539 +24
- Misses 44871 44884 +13
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
…eate-table Signed-off-by: Bugen Zhao <i@bugenzhao.com>
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Hey @BugenZhao, this pull request failed to merge and has been dequeued from the merge train. If you believe your PR failed in the merge train because of a flaky test, requeue it by clicking "Update branch" or pushing an empty commit with |
I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.
What's changed and what's your intention?
Refactor the path of handling creating streaming jobs.
gen_materialize_plan
into anothergen_table_plan
. Those table-specific arguments are not necessary forgen_materialize_plan
.mv_or_sink(v1, v2)
in thePlanRoot
.StreamMaterialize::create
into multiple methods.create
: for mview/sink/index, no table-specific arguments, columns are derived from the input.create_for_table
: for table, columns are passed-in and consistent with thebind_sql_columns
in the first step of the handler. This is a must-have for schema change that do not let theStreamMaterialize::create
handle the column ID generation.CREATE TABLE
SQL for future schema change usages.Checklist
./risedev check
(or alias,./risedev c
)Refer to a related PR or issue link (optional)