feat(frontend): show create table #7152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
BugenZhao
commented
Dec 30, 2022
| @@ -76,7 +76,7 @@ pub fn gen_create_mv_plan( | |||
|
|
|||
| let (database_id, schema_id) = session.get_database_and_schema_id_for_create(schema_name)?; | |||
|
|
|||
| let definition = query.to_string(); | |||
There was a problem hiding this comment.
With this previous method, WITH options cannot be preserved. That'll be problematic for sinks.
Codecov Report
@@ Coverage Diff @@
## main #7152 +/- ##
==========================================
+ Coverage 73.12% 73.15% +0.03%
==========================================
Files 1053 1053
Lines 167974 167994 +20
==========================================
+ Hits 122826 122902 +76
+ Misses 45148 45092 -56
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
BugenZhao
added
the
user-facing-changes
chenzl25
approved these changes
Jan 3, 2023
ZENOTME
approved these changes
Jan 3, 2023
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
yezizp2012
approved these changes
Jan 3, 2023
I guess to show this one, according to the behavior of MySQL. 🤔 It always frankly shows how to create an empty table with the same schema in one-liner. BTW, for |
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.
What's changed and what's your intention?
CREATEstatements, used forSHOW CREATElater.CREATEdefinition for materialized views and tables.SHOW CREATE TABLE.We'll use this SQL to retrieve the original definition of the table, for the first version of
ALTER TABLE ADD COLUMN. 🤣Checklist
./risedev check(or alias,./risedev c)Documentation
If your pull request contains user-facing changes, please specify the types of the changes, and create a release note. Otherwise, please feel free to remove this section.
Types of user-facing changes
Release note
Support
SHOW CREATE TABLE.Refer to a related PR or issue link (optional)