Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(frontend): Cosd function #9064

Merged
merged 39 commits into from
Apr 14, 2023
Merged

feat(frontend): Cosd function #9064

merged 39 commits into from
Apr 14, 2023

Conversation

CAJan93
Copy link
Contributor

@CAJan93 CAJan93 commented Apr 9, 2023

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Implement the Cost function. This implementation is slightly different from the PSQL implementation. I do not return an error on COSD(Inf), but instead return NaN.

Checklist For Contributors

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • I have demonstrated that backward compatibility is not broken by breaking changes and created issues to track deprecated features to be removed in the future. (Please refer to the issue)
  • All checks passed in ./risedev check (or alias, ./risedev c)

Checklist For Reviewers

  • I have requested macro/micro-benchmarks as this PR can affect performance substantially, and the results are shown.

Documentation

  • My PR DOES NOT contain user-facing changes.
Click here for Documentation

Types of user-facing changes

Please keep the types that apply to your changes, and remove the others.

  • SQL commands, functions, and operators

Release note

Implement the trigonometric function Cosd

@codecov
Copy link

codecov bot commented Apr 11, 2023

Codecov Report

Merging #9064 (455814a) into main (de7b5d4) will increase coverage by 0.01%.
The diff coverage is 94.73%.

@@            Coverage Diff             @@
##             main    #9064      +/-   ##
==========================================
+ Coverage   70.82%   70.83%   +0.01%     
==========================================
  Files        1201     1201              
  Lines      200363   200419      +56     
==========================================
+ Hits       141906   141970      +64     
+ Misses      58457    58449       -8     
Flag Coverage Δ
rust 70.83% <94.73%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/expr/src/vector_op/trigonometric.rs 95.57% <94.54%> (-0.34%) ⬇️
src/frontend/src/binder/expr/function.rs 89.52% <100.00%> (+0.01%) ⬆️

... and 5 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@CAJan93 CAJan93 requested a review from lmatz April 13, 2023 08:14
Copy link
Contributor

@lmatz lmatz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CAJan93
Copy link
Contributor Author

CAJan93 commented Apr 13, 2023

Thank you for the approval. I uncommented the float8.sql tests, which are about cosd. Let's see if it still passes

@CAJan93 CAJan93 enabled auto-merge April 14, 2023 08:26
@CAJan93 CAJan93 added the user-facing-changes Contains changes that are visible to users label Apr 14, 2023
@CAJan93 CAJan93 added this pull request to the merge queue Apr 14, 2023
Merged via the queue into main with commit c8c4827 Apr 14, 2023
@CAJan93 CAJan93 deleted the cosd branch April 14, 2023 12:59
@CharlieSYH CharlieSYH added the 📖✓ Covered or will be covered in the user docs. label Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/feature user-facing-changes Contains changes that are visible to users 📖✓ Covered or will be covered in the user docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants