-
Notifications
You must be signed in to change notification settings - Fork 594
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(frontend): Cosd function #9064
Conversation
Codecov Report
@@ Coverage Diff @@
## main #9064 +/- ##
==========================================
+ Coverage 70.82% 70.83% +0.01%
==========================================
Files 1201 1201
Lines 200363 200419 +56
==========================================
+ Hits 141906 141970 +64
+ Misses 58457 58449 -8
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 5 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the approval. I uncommented the |
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Implement the
Cost
function. This implementation is slightly different from the PSQL implementation. I do not return an error onCOSD(Inf)
, but instead returnNaN
.Checklist For Contributors
./risedev check
(or alias,./risedev c
)Checklist For Reviewers
Documentation
Click here for Documentation
Types of user-facing changes
Please keep the types that apply to your changes, and remove the others.
Release note
Implement the trigonometric function
Cosd