Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add JobDelete / JobDeleteTx APIs to Client #390

Merged
merged 3 commits into from
Jun 12, 2024
Merged

add JobDelete / JobDeleteTx APIs to Client #390

merged 3 commits into from
Jun 12, 2024

Conversation

bgentry
Copy link
Contributor

@bgentry bgentry commented Jun 11, 2024

This adds new APIs to permanently delete a job from the job table, so long as it is not currently running.

@bgentry bgentry requested a review from brandur June 11, 2024 22:30
@bgentry bgentry force-pushed the bg-job-delete branch 2 times, most recently from 4b0a79a to e86010d Compare June 11, 2024 22:36
@bgentry bgentry mentioned this pull request Jun 11, 2024
Merged
brandur
brandur reviewed Jun 12, 2024
View reviewed changes
client.go Outdated Show resolved Hide resolved
@bgentry bgentry requested a review from brandur June 12, 2024 04:01
@bgentry
add JobDelete / JobDeleteTx APIs to Client
350947d 
This adds new APIs to permanently delete a job from the job table, so
long as it is not currently running.
@bgentry
fix another flaky insertNotifyLimiter test
9207bea 
Just as in #391, the insert notify limiter uses the FetchCooldown
setting for its own debounce interval. This defaults to 100ms, which is
short enough to occasionally fail in GitHub Actions when testing two
trigger attempts back to back.
@bgentry
Copy link
Contributor Author

bgentry commented Jun 12, 2024 •
edited
Loading

Also fixed another flaky test with the same cause as #391.

brandur
brandur approved these changes Jun 12, 2024
View reviewed changes
Copy link
Contributor

@brandur brandur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

rivertype/river_type.go Outdated Show resolved Hide resolved
@bgentry @brandur
Update ErrJobRunning text
52d6bff 
Co-authored-by: Brandur Leach <brandur@brandur.org>
@bgentry bgentry merged commit 5592599 into master Jun 12, 2024
10 checks passed
@bgentry bgentry deleted the bg-job-delete branch June 12, 2024 14:52
@bgentry bgentry mentioned this pull request Jun 13, 2024
Merged
bgentry added a commit that referenced this pull request Jun 13, 2024
@bgentry
Prepare version 0.7.0
e36d135 
Prepare version 0.7.0 for release. This includes the bugfix from #376
(allow `StopAndCancel` to be called when a `Stop` is already ongoing),
and new features from #383 (allow customizing default `MaxAttempts` at
the client level) and #390 (`JobDelete` + `JobDeleteTx` APIs).
bgentry added a commit that referenced this pull request Jun 14, 2024
@bgentry
Prepare version 0.7.0 (#394)
c1aa4ee 
Prepare version 0.7.0 for release. This includes the bugfix from #376
(allow `StopAndCancel` to be called when a `Stop` is already ongoing),
and new features from #383 (allow customizing default `MaxAttempts` at
the client level) and #390 (`JobDelete` + `JobDeleteTx` APIs).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brandur brandur brandur approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bgentry @brandur