fix flaky insert notify limiter test #391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The insert notify limiter uses the FetchCooldown setting for its own debounce interval. This defaults to 100ms, which is short enough to occasionally fail in GitHub Actions when testing two trigger attempts back to back.
brandur
approved these changes
Jun 12, 2024
bgentry
added a commit
that referenced
this pull request
Jun 12, 2024
Just as in #391, the insert notify limiter uses the FetchCooldown setting for its own debounce interval. This defaults to 100ms, which is short enough to occasionally fail in GitHub Actions when testing two trigger attempts back to back.
bgentry
added a commit
that referenced
this pull request
Jun 12, 2024
* add JobDelete / JobDeleteTx APIs to Client This adds new APIs to permanently delete a job from the job table, so long as it is not currently running. * fix another flaky insertNotifyLimiter test Just as in #391, the insert notify limiter uses the FetchCooldown setting for its own debounce interval. This defaults to 100ms, which is short enough to occasionally fail in GitHub Actions when testing two trigger attempts back to back. * Update ErrJobRunning text Co-authored-by: Brandur Leach <brandur@brandur.org> --------- Co-authored-by: Brandur Leach <brandur@brandur.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The insert notify limiter uses the FetchCooldown setting for its own debounce interval. This defaults to 100ms, which is short enough to occasionally fail in GitHub Actions when testing two trigger attempts back to back.
Failed on this run: