feat(sdks/actor): add http api for calling rpcs #1950
Conversation
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR adds HTTP RPC support to the Rivet actor system, enabling RPC calls over HTTP alongside existing WebSocket connections, with improved development workflows.
- Added HTTP RPC endpoint
/rpc/:nameinsdks/actor/runtime/src/actor.tswith proper request validation and error handling - Introduced Zod schemas in
sdks/actor/protocol/src/http/rpc.tsfor runtime validation of HTTP RPC requests/responses - Modified
Connectionclass insdks/actor/runtime/src/connection.tsto support optional WebSocket connections for HTTP-only RPCs - Changed WebSocket connection URL format from
/connect?version=1&format=...to/v1/connect?format=...insdks/actor/client/src/handle.ts - Added
devscripts with watch mode across multiple packages for improved development workflow
8 file(s) reviewed, 7 comment(s)
Edit PR Review Bot Settings | Greptile
| @@ -31,6 +31,7 @@ | |||
| "sideEffects": false, | |||
| "scripts": { | |||
| "build": "tsup src/mod.ts src/query.ts", | |||
| "dev": "yarn build --watch", | |||
There was a problem hiding this comment.
style: consider using 'tsup --watch' directly instead of 'yarn build --watch' to avoid potential yarn command resolution issues
| @@ -22,6 +22,7 @@ | |||
| "sideEffects": false, | |||
| "scripts": { | |||
| "build": "tsup src/mod.ts", | |||
| "dev": "yarn build --watch", | |||
There was a problem hiding this comment.
style: consider using tsup src/mod.ts --watch directly instead of yarn build --watch to avoid potential issues with yarn command resolution
| } | ||
| export const RequestSchema = z.object({ | ||
| // Args | ||
| a: z.array(z.unknown()), |
There was a problem hiding this comment.
style: consider adding validation for empty arrays since they likely indicate invalid RPC calls
| } | ||
| export const ResponseOkSchema = z.object({ | ||
| // Output | ||
| o: z.unknown(), |
There was a problem hiding this comment.
style: consider adding validation for null/undefined output values which could indicate bugs in RPC handlers
| // Message | ||
| m: z.string(), | ||
| // Metadata | ||
| md: z.unknown().optional(), |
There was a problem hiding this comment.
logic: metadata should be z.record() instead of z.unknown() to ensure object type
| @@ -64,6 +64,7 @@ | |||
| "sideEffects": false, | |||
| "scripts": { | |||
| "build": "tsup src/http/rpc.ts src/http/inspect.ts src/ws/mod.ts src/ws/to_client.ts src/ws/to_server.ts", | |||
| "dev": "yarn build --watch", | |||
There was a problem hiding this comment.
style: consider using 'tsup --watch' directly instead of 'yarn build --watch' for better cross-platform compatibility
| const contentLength = Number(c.req.header("content-length") || "0"); | ||
| if (contentLength > this.#config.protocol.maxIncomingMessageSize) { | ||
| throw new errors.MessageTooLong(); |
There was a problem hiding this comment.
logic: Content-Length validation happens after parsing the body. Move this check before c.req.json() to prevent potential DoS attacks.
Deploying rivet with
|
| Latest commit: |
b8aefc8
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://036625ae.rivet.pages.dev |
| Branch Preview URL: | https://01-23-feat-sdks-actor-add-ht.rivet.pages.dev |
Merge activity
|
<!-- Please make sure there is an issue that this PR is correlated to. --> ## Changes <!-- If there are frontend changes, please include screenshots. -->
graphite-app
bot
deleted the
01-23-feat_sdks_actor_add_http_api_for_calling_rpcs
branch
Changes