fix(sdks/actor/runtime): fix internal errors not getting logged & make UserError public #1958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e UserError public
This was referenced Jan 28, 2025
Closed
Deploying rivet with
|
| Latest commit: |
5189118
|
| Status: | 🚫 Build failed. |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Improved error handling and logging in the actor runtime by centralizing error management and adjusting error visibility.
- Removed
public: truefromStateTooLargeerror insdks/actor/runtime/src/errors.tsto prevent exposing memory limitations - Added explicit
public: trueflag toUserErrorconstructor for consistent user-facing error handling - Centralized error logging in
sdks/actor/runtime/src/event.tswith different log levels for public (info) and internal (warn) errors - Removed redundant
onErrorhandlers from WebSocket handling insdks/actor/runtime/src/actor.tsandsdks/actor/runtime/src/inspect.ts - Added connection and RPC context to error logs for better debugging in
sdks/actor/runtime/src/event.ts
4 file(s) reviewed, 2 comment(s)
Edit PR Review Bot Settings | Greptile
| @@ -174,7 +174,7 @@ export interface UserErrorOptions extends ErrorOptions { | |||
| metadata: unknown; | |||
There was a problem hiding this comment.
logic: metadata is marked as required but opts is optional - this could cause runtime errors if opts is undefined
Comment on lines
+148
to
+153
| logger().warn("internal error", { | ||
| error: String(error), | ||
| connectionId: conn.id, | ||
| rpcId, | ||
| rpcName, | ||
| }); |
There was a problem hiding this comment.
style: consider adding stack trace to internal error logs for better debugging
This was referenced Jan 29, 2025
Closed
Merge activity
|
NathanFlurry
added a commit
that referenced
this pull request
Jan 30, 2025
…e UserError public (#1958) <!-- Please make sure there is an issue that this PR is correlated to. --> ## Changes <!-- If there are frontend changes, please include screenshots. -->
graphite-app
bot
deleted the
01-28-fix_sdks_actor_runtime_fix_internal_errors_not_getting_logged_make_usererror_public
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes