chore(hub-embed): auto-build & embed hub instead of pulling from releases #1966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying rivet-hub with
|
| Latest commit: |
4bce14d
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://27662316.rivet-hub-7jb.pages.dev |
| Branch Preview URL: | https://01-29-chore-hub-embed-auto-b.rivet-hub-7jb.pages.dev |
This was referenced Jan 30, 2025
Closed
Closed
This was referenced Jan 30, 2025
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR modifies the hub-embed package to build and embed the hub UI directly from source during compilation, replacing the previous approach of pulling from releases.
- Changed
packages/common/hub-embed/build.rsto build hub UI using yarn/turbo instead of downloading pre-built releases - Added new
build:embeddedtask infrontend/apps/hub/turbo.jsonandpackage.jsonwith/ui/base path - Updated placeholder from
%VITE_APP_API_URL%to__VITE_APP_API_URL__inpackages/api/ui/src/route.rsfor API URL injection - Security concern: Removed
.env*from.gitignorewhich could expose sensitive information - Added
fs_extrabuild dependency inpackages/common/hub-embed/Cargo.tomlfor directory operations
6 file(s) reviewed, 4 comment(s)
Edit PR Review Bot Settings | Greptile
| @@ -61,7 +61,6 @@ tests/basic-game/.env | |||
| # Added by cargo | |||
|
|
|||
| /target | |||
There was a problem hiding this comment.
style: Duplicate /target entry - already covered by **/target on line 48
Suggested change
| /target |
| @@ -61,7 +61,6 @@ tests/basic-game/.env | |||
| # Added by cargo | |||
|
|
|||
| /target | |||
| .env* | |||
| .yarn/cache | |||
| .yarn/install-state.gz | |||
| .turbo | |||
There was a problem hiding this comment.
style: Duplicate .turbo entry - already defined on line 56
Suggested change
| .turbo |
Comment on lines
+9
to
+10
| let project_root = PathBuf::from(manifest_dir.clone()).join("../../.."); | ||
| let hub_path = project_root.join("frontend/apps/hub"); |
There was a problem hiding this comment.
logic: Path traversal could fail if manifest_dir is at root. Consider using canonicalize() to resolve the absolute path.
Comment on lines
+31
to
+37
| let dist_path = hub_path.join("dist"); | ||
| fs::create_dir_all(out_dir)?; | ||
| fs_extra::dir::copy( | ||
| dist_path, | ||
| out_dir, | ||
| &fs_extra::dir::CopyOptions::new().overwrite(true), | ||
| )?; |
There was a problem hiding this comment.
logic: No check if dist_path exists before copying. Build could silently fail if dist directory wasn't created.
Suggested change
| let dist_path = hub_path.join("dist"); | |
| fs::create_dir_all(out_dir)?; | |
| fs_extra::dir::copy( | |
| dist_path, | |
| out_dir, | |
| &fs_extra::dir::CopyOptions::new().overwrite(true), | |
| )?; | |
| let dist_path = hub_path.join("dist"); | |
| if !dist_path.exists() { | |
| return Err("Build failed: dist directory not created".into()); | |
| } | |
| fs::create_dir_all(out_dir)?; | |
| fs_extra::dir::copy( | |
| dist_path, | |
| out_dir, | |
| &fs_extra::dir::CopyOptions::new().overwrite(true), | |
| )?; |
Deploying rivet with
|
| Latest commit: |
4bce14d
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://025b14f6.rivet.pages.dev |
| Branch Preview URL: | https://01-29-chore-hub-embed-auto-b.rivet.pages.dev |
This was referenced Jan 30, 2025
Closed
Merge activity
|
NathanFlurry
added a commit
that referenced
this pull request
Jan 30, 2025
…ases (#1966) <!-- Please make sure there is an issue that this PR is correlated to. --> ## Changes <!-- If there are frontend changes, please include screenshots. -->
graphite-app
bot
deleted the
01-29-chore_hub-embed_auto-build_embed_hub_instead_of_pulling_from_releases
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes