Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(pegboard): handle conflicts for client events gracefully #1647

Closed
wants to merge 1 commit into from
Closed

fix(pegboard): handle conflicts for client events gracefully #1647

wants to merge 1 commit into from

Conversation

NathanFlurry
Copy link
Member

Changes

@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Dec 18, 2024 •
edited
Loading

Deploying rivet with  Cloudflare Pages  Cloudflare Pages

Latest commit: c152a11
Status: ✅  Deploy successful!
Preview URL: https://c11121b0.rivet.pages.dev
Branch Preview URL: https://12-18-fix-pegboard-handle-co.rivet.pages.dev

View logs

This was referenced Dec 18, 2024
Closed
Closed
Closed
Closed
Closed
@NathanFlurry Graphite App
Copy link
Member Author

NathanFlurry commented Dec 18, 2024 •
edited
Loading

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

How to use the Graphite Merge Queue

Add the label merge-queue to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has required the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@NathanFlurry NathanFlurry mentioned this pull request Dec 18, 2024
Closed
@NathanFlurry NathanFlurry force-pushed the 12-18-chore_cluster_remove_dns_records_when_pruning_servers branch from 6f91eb2 to c524a75 Compare December 19, 2024 01:05
@NathanFlurry NathanFlurry force-pushed the 12-18-fix_pegboard_handle_conflicts_for_client_events_gracefully branch from 61ca8ed to 31a2c8e Compare December 19, 2024 01:05
This was referenced Dec 19, 2024
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@NathanFlurry NathanFlurry force-pushed the 12-18-chore_cluster_remove_dns_records_when_pruning_servers branch from c524a75 to 5a53b0b Compare December 19, 2024 07:01
@NathanFlurry NathanFlurry force-pushed the 12-18-fix_pegboard_handle_conflicts_for_client_events_gracefully branch from 31a2c8e to c152a11 Compare December 19, 2024 07:01
@NathanFlurry NathanFlurry mentioned this pull request Dec 19, 2024
Closed
@graphite-app Graphite App
Copy link
Contributor

graphite-app bot commented Dec 19, 2024 •
edited
Loading

Merge activity

  • Dec 19, 4:40 PM EST: A user added this pull request to the Graphite merge queue.
  • Dec 19, 4:42 PM EST: CI is running for this PR on a draft PR: #1659
  • Dec 19, 4:46 PM EST: A user merged this pull request with the Graphite merge queue via draft PR: #1659.

NathanFlurry added a commit that referenced this pull request Dec 19, 2024
@NathanFlurry
fix(pegboard): handle conflicts for client events gracefully (#1647)
fc13e83 
<!-- Please make sure there is an issue that this PR is correlated to. -->

## Changes

<!-- If there are frontend changes, please include screenshots. -->
@graphite-app graphite-app bot deleted the branch 12-18-chore_cluster_remove_dns_records_when_pruning_servers December 19, 2024 21:46
@graphite-app graphite-app bot closed this Dec 19, 2024
@graphite-app graphite-app bot closed this Dec 19, 2024
@graphite-app graphite-app bot deleted the 12-18-fix_pegboard_handle_conflicts_for_client_events_gracefully branch December 19, 2024 21:46
@github-actions github-actions bot mentioned this pull request Dec 19, 2024
Merged
MasterPtato
MasterPtato requested changes Dec 23, 2024
View reviewed changes
Copy link
Contributor

@MasterPtato MasterPtato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be reverted once we find the fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MasterPtato MasterPtato MasterPtato requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NathanFlurry @MasterPtato