drawScreen should get an isVisible flag to allow screens to clean up resources they don't need #16
Comments
zach-klippenstein
added a commit
that referenced
this issue
Mar 15, 2021
- All the actual transition logic is moved out of the `Backstack` composable and into `TransitionController`. - `BackstackInspector` and `InspectionGestureDetector` are replaced with a single API in a new, dedicated module: `xrayed()`. - `Backstack` now just handles the container and managing saveable state. - Introduces `FrameController`, an abstraction which can be used to implement both transitions, the inspector functionality, and things like #17. - Removes the spring animations from the inspector. They added unnecessary lag to the gestures. - Adds more tests for state handling. - Fixed some races that caused navigation animation glitches. This change fixes a number of issues: - Closes #4 - Closes #5 - Closes #16 - Closes #42 - Closes #44 (camera distance API is used to improve the 3D view, but not for zooming itself) - Unblocks #17
zach-klippenstein
added a commit
that referenced
this issue
Mar 15, 2021
- All the actual transition logic is moved out of the `Backstack` composable and into `TransitionController`. - `BackstackInspector` and `InspectionGestureDetector` are replaced with a single API in a new, dedicated module: `xrayed()`. - `Backstack` now just handles the container and managing saveable state. - Introduces `FrameController`, an abstraction which can be used to implement both transitions, the inspector functionality, and things like #17. - Removes the spring animations from the inspector. They added unnecessary lag to the gestures. - Adds more tests for state handling. - Fixed some races that caused navigation animation glitches. This change fixes a number of issues: - Closes #4 - Closes #5 - Closes #16 - Closes #42 - Closes #44 (camera distance API is used to improve the 3D view, but not for zooming itself) - Unblocks #17
zach-klippenstein
added a commit
that referenced
this issue
Mar 15, 2021
- All the actual transition logic is moved out of the `Backstack` composable and into `TransitionController`. - `BackstackInspector` and `InspectionGestureDetector` are replaced with a single API in a new, dedicated module: `xrayed()`. - `Backstack` now just handles the container and managing saveable state. - Introduces `FrameController`, an abstraction which can be used to implement both transitions, the inspector functionality, and things like #17. - Removes the spring animations from the inspector. They added unnecessary lag to the gestures. - Adds more tests for state handling. - Fixed some races that caused navigation animation glitches. This change fixes a number of issues: - Closes #4 - Closes #5 - Closes #16 - Closes #42 - Closes #44 (camera distance API is used to improve the 3D view, but not for zooming itself) - Unblocks #17
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This is another hack until the UiSavedStateRegistry stuff gets released. Once that happens, we can probably just drop all hidden screens immediately and don't need this.
The text was updated successfully, but these errors were encountered: