Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Completely rewrite the internals and most of the APIs. #50

Merged
merged 1 commit into from
Mar 15, 2021

Conversation

zach-klippenstein
Copy link
Collaborator

  • All the actual transition logic is moved out of the Backstack composable and into TransitionController.
  • BackstackInspector and InspectionGestureDetector are replaced with a single API in a new, dedicated module: xrayed().
  • Backstack now just handles the container and managing saveable state.
  • Introduces FrameController, an abstraction which can be used to implement both transitions, the inspector functionality, and things like Consider API for manually controlling transition #17.
  • Removes the spring animations from the inspector. They added unnecessary lag to the gestures.
  • Adds more tests for state handling.
  • Fixed some races that caused navigation animation glitches.

This change fixes a number of issues:

- All the actual transition logic is moved out of the `Backstack` composable and into `TransitionController`.
- `BackstackInspector` and `InspectionGestureDetector` are replaced with a single API in a new, dedicated module: `xrayed()`.
- `Backstack` now just handles the container and managing saveable state.
- Introduces `FrameController`, an abstraction which can be used to implement both transitions, the inspector functionality, and things like #17.
- Removes the spring animations from the inspector. They added unnecessary lag to the gestures.
- Adds more tests for state handling.
- Fixed some races that caused navigation animation glitches.

This change fixes a number of issues:
- Closes #4
- Closes #5
- Closes #16
- Closes #42
- Closes #44 (camera distance API is used to improve the 3D view, but not for zooming itself)
- Unblocks #17
Base automatically changed from zachklipp/binary-validator to main March 15, 2021 07:01
@zach-klippenstein zach-klippenstein merged commit c093774 into main Mar 15, 2021
@zach-klippenstein zach-klippenstein deleted the zachklipp/cleanup-api branch March 15, 2021 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment