-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more tests for filtering mutations, more specific var-type options, option for controlling number of parallel threads (--jobs) #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bs, indel matching.
…es for all. Need to test everything that's not 'covsonar_dna'
Closes #13 |
|
Var-type is printed already at the start
Features are now joined with user-defined sep instead of space at the end of filter_features
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kind of a potpourri of a PR (sorry), containing extra testing of the feature filtering (skipping indels, trimming mutations at the ends of the genome) and solutions to issues with that which came up.
Also took this as an opportunity to add the ability to set the number of parallel threads that are used by the distance calculation (
--jobs
), which formerly had to be set using theOMP_NUM_THREADS
environment variable. Lastly added a few extra checks to ensure that the program aborts in certain cases, like when there are duplicate sequence IDs in the input table.