Config overhaul #359
Merged
Config overhaul #359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Still cleaning some things up but it's functional. Translates old config formts (both vim globals and old lua) to the new names. Also shows the new config in `:healthcheck`
Sometimes deleting a session from the the Telescope picker wasn't working. It happens when we have extra command files that are filtered out from the list. Those files break some code in Telescope that finds the item we want to delete in the picker results. More detail is here: nvim-telescope/telescope.nvim#3265 We work around the issue by having the Telescope entry maker returning {} instead of nil. That's not perfect but better than not being able to delete/
And shows you what the new config should be
We had been relying on `v:errmsg` to catch session errors when restoring with `silent! source <session>`. The problem with that approach is `v:errmsg` might be set even when it's an error message that should be ignored (e.g. by another `silent!` command). Instead, we now `silent source <session>` (note no !) but if that fails (which means it's a real error), then we optionally source the session again, this time with silent! so we load as much of the session as possible.
Fixes rmagatti#350 Also update `continue_restore_on_error` description
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new config should be backwards compatible with the previous names but I'll still mention it in the breaking changes thread just in case.
Also includes: