-
-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added plugin support for EuroDNS #580
Conversation
Congratulations, @zoryatix! At first glance, this looks great. The only minor thing you might want to do in future PRs is put your changes in their own git branch. It makes it a tiny bit easier for someone to pull down your branch to their local repo for testing. Give me a bit to review things more thoroughly and we'll get this merged. |
Thanks - git is a whole new world for me. Thanks for taking the time to explain the flow, I'll keep that in mind. |
I just noticed that the user guide talks about getting API credentials by contacting support through a reseller. What about customers who purchase directly through EuroDNS? Ironically, despite there clearly being API documentation, I can't actually find a reference on their site that the API exists or how to get credentials for it. |
That is very good question. I tried reaching out to EuroDNS through their support site, asking a question during development. They just sent that question back to ebrand. My contact at ebrand said that all communication should go through them. So, it's a bit of a weird setup. I had to get my api key through my contact person at ebrand. Assuming that they contacted eurodns on my behalf. |
Plot thickens. I reached out to EuroDNS support to ask how to generate API credentials and this was their response.
It sounds like EBrand is essentially distributing credentials on behalf of their reseller status that aren't necessarily intended for end users (unless you actually are a reseller). I'm not opposed to adding the plugin as-is. But I'll probably update the guide to say it's only going to be useful if you're a EuroDNS reseller or a customer of a reseller that is willing to generate API credentials on your behalf. I'm also trying to decide whether the name should change to something like |
Nice find - I had no idea the structure was setup like that. I don't mind the name change, but many of the functions i built were using EuroDNS in their name, so that would also need to be changed, to avoid a conflict in case someone builds a plugin for the "new api". The name EuroDNSResller sounds good to me as long as documentation mentions ebrand, so that people searching for that name can find the plugin. |
I just noticed that you've got a bug in the code that tries to parse the zone/domain from
The typical way plugins handle this is by querying the provider for increasingly generic portions of the $RecordName until it either finds a match or gives up and throws an error. So if your
Have a look at the DOcean plugin's |
Ohh nice catch - I'll take a look at DOcean and create a fix for mine. I might as well rename the plugin. I'm happy with EuroDNSReseller, so I'll go ahead and change it to that if you don't mind. |
Closing in favor of #590 |
First time doing a pull request. No idea if I'm doing this right.
Below has been tested according to the plugin development guide and have successfully been able to get a certificate through the:
New-PACertificate '*.MyExampleDomain.com','MyExampleDomain.com' -AcceptTOS -Contact 'contact@MyExampleDomain.com' -Plugin EuroDNS -PluginArgs $pArgs -Verbose