Adding plugin support for EuroDNSReseller #590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry for the delay. Real work always gets busy around the holidays. I tweaked the guide a bit. I also re-added the recShort fix that got pushed to main in another issue recently. That ended up making a bunch of whitespace changes as well. Can you double check the updated version and make sure it's still working for you? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I followed your advice from pr #580 and created a branch for this change. I've renamed the plugin to better reflect its origin.
I've changed the way I handle domains/tld - So now it will also work with 2 level tld's.
Successfully tested with following:
Let me know if I've missed anything.