Try to fix 1.9-dev branch #1849
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously this used `instance_exec` which sets `self` to the field instance. This changes to `yield` which still yields the field instance (supporting the same functionality) but doesn't change `self`.
add GraphQL::Types::ISO8601DateTime.time_precision to customize time pricisions
support callable prepare objects in Schema::Argument (fixes #1786)
…yielding Update how Schema::Field executes definition_block
Make language nodes immutable
[Language::Visitor] use method-based visit handlers
Manipulate AST with visitor
Field Extensions (second try)
Don't pass resolver objects to field extensions
Change the default behavior of the encoder to use `urlsafe` versions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A while ago, I was trying to get
masterchanges into 1.9-dev, and somehow, I broke it. It had something to do with field extensions, and how it was reverted on master.So I just now made a new branch from master, cherry-picked all the merge commits from https://github.com/rmosolgo/graphql-ruby/milestone/67?closed=1, and now I think I can merge that into 1.9-dev and maybe we'll be in good shape.