Put 1.9-dev on master #2038
Merged
Put 1.9-dev on master #2038
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change the default behavior of the encoder to use `urlsafe` versions
Make language nodes immutable
[Language::Visitor] use method-based visit handlers
Manipulate AST with visitor
Field Extensions (second try)
Don't pass resolver objects to field extensions
Change the default behavior of the encoder to use `urlsafe` versions
Try to fix 1.9-dev branch
Fix introspection on interpreter
Add AST::Visitor#previous_field_definition
[1.9] Look for perf wins in AST analysis
…thods Add Field#resolver_method, remove `super` on field methods
1.9 hash key schema fix
Add warning for proc-based visitors
This allows better reporting of codes without the need to use `to_h`. It's also better for subclasses as they can modify if they need to. Which for fine grained reporting they would want to. I'm sure I had good reasons to make this private originally, but use cases now show this would be a much better solution.
Allow code to be accessed outside of the errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still a few items to knock out before releasing (#1884), but I think things are stable enough to make this a default.
We can always backport changes to 1.8 if needed.