-
-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove PHP versions from GitHub Actions, fix the documentation link #26
Conversation
WalkthroughThe recent updates involve loosening the restrictions on workflow triggers by removing the Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 2
Configuration used: CodeRabbit UI
Files ignored due to path filters (1)
composer.json
is excluded by:!**/*.json
Files selected for processing (3)
- .github/workflows/phpunit.yml (2 hunks)
- .github/workflows/psalm.yml (2 hunks)
- README.md (1 hunks)
Files skipped from review due to trivial changes (2)
- .github/workflows/phpunit.yml
- README.md
@@ -1,7 +1,6 @@ | |||
on: | |||
push: | |||
branches: | |||
- master | |||
- '*.*' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The branch trigger has been updated to '*.*'
, which might not behave as intended if the goal was to trigger on all branches. This pattern matches branches with a dot in their names, potentially excluding branches named without dots, such as main
or develop
.
Consider using '**'
to include all branches if that's the intended behavior.
on: | ||
push: | ||
branches: | ||
- master | ||
- '*.*' | ||
pull_request: null | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📝 NOTE
This review was outside the diff hunks and was mapped to the diff hunk with the greatest overlap. Original lines [4-12]
The removal of the PHP version configuration is not directly shown, but its absence could lead to the workflow running on the default PHP version provided by the ubuntu-latest
environment. This might not align with the project's PHP version requirements.
Consider specifying the PHP version explicitly or ensuring the default version meets the project's needs.
Summary by CodeRabbit
master
branch restriction for pushes in GitHub workflows.